netdev - Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622131650.GD2557669@bistromath.localdomain>
Date:   Mon, 22 Jun 2020 15:16:50 +0200
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Xin Long <lucien.xin@...il.com>
Cc:     netdev@...r.kernel.org,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct
 xfrm_tunnel

2020-06-17, 01:36:27 +0800, Xin Long wrote:
> @@ -231,6 +255,7 @@ static int __init tunnel4_init(void)
>  		goto err;
>  	}
>  #endif
> +	xfrm_input_register_afinfo(&tunnel4_input_afinfo);

This can fail. Shouldn't you handle that error?

>  	return 0;
>  
>  err:

-- 
Sabrina