netdev - Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_ekuzyKkAYg1uMhYRQv-FWgHZwftCpdqdCc6gtvxDyajw@mail.gmail.com>
Date:   Tue, 23 Jun 2020 01:18:39 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
Cc:     network dev <netdev@...r.kernel.org>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm_tunnel

On Mon, Jun 22, 2020 at 9:16 PM Sabrina Dubroca <sd@...asysnail.net> wrote:
>
> 2020-06-17, 01:36:27 +0800, Xin Long wrote:
> > @@ -231,6 +255,7 @@ static int __init tunnel4_init(void)
> >               goto err;
> >       }
> >  #endif
> > +     xfrm_input_register_afinfo(&tunnel4_input_afinfo);
>
> This can fail. Shouldn't you handle that error?
Yeah, I copied it from xfrm4_protocol_init().
Now I see why it didn't in xfrm4_protocol_init().

Thanks.

>
> >       return 0;
> >
> >  err:
>
> --
> Sabrina
>