netdev - Re: [PATCH net-next v3 4/7] net: phy: add backplane kr driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Jun 2020 00:29:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Florinel Iordache <florinel.iordache@....com>, davem@...emloft.net,
        netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com,
        hkallweit1@...il.com, linux@...linux.org.uk
Cc:     kbuild-all@...ts.01.org, devicetree@...r.kernel.org,
        linux-doc@...r.kernel.org, robh+dt@...nel.org, mark.rutland@....com
Subject: Re: [PATCH net-next v3 4/7] net: phy: add backplane kr driver support

Hi Florinel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Florinel-Iordache/doc-net-add-backplane-documentation/20200622-223623
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 29a720c1042f469c8fea317cb5e7f496b116e07d
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/net/phy/backplane/backplane.c: In function 'bp_kr_state_machine':
>> drivers/net/phy/backplane/backplane.c:590:27: warning: variable 'bpdev' set but not used [-Wunused-but-set-variable]
590 |  struct backplane_device *bpdev;
|                           ^~~~~
--
drivers/net/phy/backplane/link_training.c: In function 'lt_train_remote_tx':
>> drivers/net/phy/backplane/link_training.c:557:6: warning: variable 'lp_resp_time' set but not used [-Wunused-but-set-variable]
557 |  u64 lp_resp_time;
|      ^~~~~~~~~~~~
drivers/net/phy/backplane/link_training.c: In function 'lt_train_local_tx':
>> drivers/net/phy/backplane/link_training.c:1143:15: warning: variable 'old_ld_status' set but not used [-Wunused-but-set-variable]
1143 |  int request, old_ld_status;
|               ^~~~~~~~~~~~~

vim +/bpdev +590 drivers/net/phy/backplane/backplane.c

   586	
   587	static void bp_kr_state_machine(struct work_struct *work)
   588	{
   589		struct delayed_work *dwork = to_delayed_work(work);
 > 590		struct backplane_device *bpdev;
   591		u32 kr_timeout = KR_TIMEOUT_1;
   592		struct phy_device *phydev;
   593		struct lane_device *lane;
   594		bool start_train = false;
   595	
   596		lane = container_of(dwork, struct lane_device, krwk);
   597		if (!lane)
   598			return;
   599	
   600		bpdev = lane->bpdev;
   601		phydev = lane->phydev;
   602	
   603		if (!backplane_is_mode_kr(phydev->interface))
   604			return;
   605	
   606		/* Check if equalization algorithm is installed */
   607		if (!lane->krln.eq_alg)
   608			return;
   609	
   610		/* Check if link training is used */
   611		if (!lane->krln.eq_alg->use_local_tx_training &&
   612		    !lane->krln.eq_alg->use_remote_tx_training)
   613			return;
   614	
   615		mutex_lock(&lane->lane_lock);
   616		switch (lane->krln.state) {
   617		case DETECTING_LP:
   618			start_train = detect_lp(lane);
   619			break;
   620		case TRAINED:
   621			kr_timeout = KR_TIMEOUT_2;
   622			if (!backplane_is_link_up(phydev)) {
   623				kr_timeout = KR_TIMEOUT_1;
   624				detect_hotplug(lane);
   625			}
   626			break;
   627		}
   628	
   629		if (start_train)
   630			kr_train_step(lane);
   631	
   632		mutex_unlock(&lane->lane_lock);
   633		start_kr_state_machine(lane, kr_timeout);
   634	}
   635	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (67062 bytes)