lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 22 Jun 2020 19:33:48 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Yehezkel Bernat <yehezkelshb@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, Michael Jamet <michael.jamet@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Lukas Wunner <lukas@...ner.de>, netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

On Tue, Jun 16, 2020 at 02:55:25PM +0300, Mika Westerberg wrote:
> On Mon, Jun 15, 2020 at 10:54:52PM +0300, Yehezkel Bernat wrote:
> > On Mon, Jun 15, 2020 at 6:55 PM Mika Westerberg
> > <mika.westerberg@...ux.intel.com> wrote:
> > >
> > > On Mon, Jun 15, 2020 at 06:41:32PM +0300, Yehezkel Bernat wrote:
> > > > > I think you are talking about the "prtstns" property in the network
> > > > > driver. There we only set TBNET_MATCH_FRAGS_ID (bit 1). This is the
> > > > > thing that get exposed to the other side of the connection and we never
> > > > > announced support for full E2E.
> > > >
> > > >
> > > > Ah, yes, this one, Thanks!
> > > > As Windows driver uses it for flagging full-E2E, and we completely drop E2E
> > > > support here, it may worth to mention there that this is what bit 2 is used in
> > > > Windows so any reuse should consider the possible compatibility issue.
> > >
> > > Note we only drop dead code in this patch. It is that workaround for
> > > Falcon Ridge controller we actually never used.
> > >
> > > I can add a comment to the network driver about the full E2E support
> > > flag as a separate patch if you think it is useful.
> > >
> > > The network protocol will be public soon I guess because USB4 spec
> > > refers to "USB4 Inter-Domain Specification, Revision 1.0, [to be
> > > published] – (USB4 Inter-Domain Specification)" so I would expect it to
> > > be explained there as well.
> > 
> > I see. I leave it for your decision, then.
> > Thanks for bearing with me.
> 
> OK, I think it makes sense to add the comment so I'll do that as
> a separate patch (will probably go next week since I have some other
> patches to deal with this week, and Friday is holiday in Finland).

OK, I sent it now and can be found here:

  https://lore.kernel.org/netdev/20200622163022.53298-1-mika.westerberg@linux.intel.com/

Powered by blists - more mailing lists