[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200622151520.79ab2af9@kicinski-fedora-PC1C0HJN>
Date: Mon, 22 Jun 2020 15:15:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Luo bin <luobin9@...wei.com>
Cc: <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
<netdev@...r.kernel.org>, <luoxianjun@...wei.com>,
<yin.yinshi@...wei.com>, <cloud.wangxiaoyun@...wei.com>
Subject: Re: [PATCH net-next v1 5/5] hinic: add support to get eeprom
information
On Sat, 20 Jun 2020 17:42:58 +0800 Luo bin wrote:
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_port.h b/drivers/net/ethernet/huawei/hinic/hinic_port.h
> index 5c916875f295..0d0354241345 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_port.h
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_port.h
> @@ -677,6 +677,37 @@ struct hinic_led_info {
> u8 reset;
> };
>
> +#define MODULE_TYPE_SFP 0x3
> +#define MODULE_TYPE_QSFP28 0x11
> +#define MODULE_TYPE_QSFP 0x0C
> +#define MODULE_TYPE_QSFP_PLUS 0x0D
> +
> +#define STD_SFP_INFO_MAX_SIZE 640
Please use the existing defines, e.g. from #include <linux/sfp.h>
there is no need for every driver to redefine those constants.
Powered by blists - more mailing lists