[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ee54d69c-2c94-7c40-4a92-761a73445e14@huawei.com>
Date: Tue, 23 Jun 2020 14:40:28 +0800
From: "luobin (L)" <luobin9@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
<netdev@...r.kernel.org>, <luoxianjun@...wei.com>,
<yin.yinshi@...wei.com>, <cloud.wangxiaoyun@...wei.com>
Subject: Re: [PATCH net-next v1 2/5] hinic: add support to set and get irq
coalesce
On 2020/6/23 6:07, Jakub Kicinski wrote:
> On Sat, 20 Jun 2020 17:42:55 +0800 Luo bin wrote:
>> @@ -1144,8 +1190,16 @@ static int nic_dev_init(struct pci_dev *pdev)
>> goto err_reg_netdev;
>> }
>>
>> + err = hinic_init_intr_coalesce(nic_dev);
>> + if (err) {
>> + netif_err(nic_dev, drv, netdev, "Failed to init_intr_coalesce\n");
>> + goto err_init_intr;
>> + }
>> +
>> return 0;
>>
>> +err_init_intr:
>> + unregister_netdev(netdev);
>> err_reg_netdev:
>> err_set_features:
>> hinic_hwdev_cb_unregister(nic_dev->hwdev,
>
> A little suspicious - you should finish all init before device is
> registered, once registered the interface can be immediately brought
> up.
> .
>
Will fix. Thanks for your review.
Powered by blists - more mailing lists