netdev - Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data concatenation pattern test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ed6ada5-2539-3090-0db7-0f65b67e4699@iogearbox.net>
Date:   Tue, 23 Jun 2020 22:39:13 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, john.fastabend@...il.com
Cc:     andrii.nakryiko@...il.com, kernel-team@...com
Subject: Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data
 concatenation pattern test

Hey Andrii,

On 6/23/20 5:22 AM, Andrii Nakryiko wrote:
> Add selftest that validates variable-length data reading and concatentation
> with one big shared data array. This is a common pattern in production use for
> monitoring and tracing applications, that potentially can read a lot of data,
> but overall read much less. Such pattern allows to determine precisely what
> amount of data needs to be sent over perfbuf/ringbuf and maximize efficiency.
> 
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Currently getting the below errors on these tests. My last clang/llvm git build
is on 4676cf444ea2 ("[Clang] Skip adding begin source location for PragmaLoopHint'd
loop when[...]"):

# ./test_progs -t varlen
test_varlen:PASS:skel_open 0 nsec
test_varlen:PASS:skel_attach 0 nsec
test_varlen:FAIL:check got 0 != exp 8
test_varlen:FAIL:check got 0 != exp 7
test_varlen:FAIL:check got 0 != exp 15
test_varlen:FAIL:content_check doesn't match!test_varlen:FAIL:check got 0 != exp 8
test_varlen:FAIL:check got 0 != exp 7
test_varlen:FAIL:check got 0 != exp 15
test_varlen:FAIL:content_check doesn't match!test_varlen:FAIL:check got 0 != exp 8
test_varlen:FAIL:check got 0 != exp 7
test_varlen:FAIL:check got 0 != exp 15
test_varlen:FAIL:content_check doesn't match!test_varlen:FAIL:check got 0 != exp 8
test_varlen:FAIL:check got 0 != exp 7
test_varlen:FAIL:check got 0 != exp 15
test_varlen:FAIL:content_check doesn't match!
#87 varlen:FAIL
Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED

# ./test_progs-no_alu32 -t varlen
Switching to flavor 'no_alu32' subdirectory...
test_varlen:PASS:skel_open 0 nsec
test_varlen:PASS:skel_attach 0 nsec
test_varlen:FAIL:check got 0 != exp 8
test_varlen:FAIL:check got 0 != exp 7
test_varlen:FAIL:check got 0 != exp 15
test_varlen:FAIL:content_check doesn't match!test_varlen:FAIL:check got 0 != exp 8
test_varlen:FAIL:check got 0 != exp 7
test_varlen:FAIL:check got 0 != exp 15
test_varlen:FAIL:content_check doesn't match!test_varlen:FAIL:check got 0 != exp 8
test_varlen:FAIL:check got 0 != exp 7
test_varlen:FAIL:check got 0 != exp 15
test_varlen:FAIL:content_check doesn't match!test_varlen:FAIL:check got 0 != exp 8
test_varlen:FAIL:check got 0 != exp 7
test_varlen:FAIL:check got 0 != exp 15
test_varlen:FAIL:content_check doesn't match!
#87 varlen:FAIL
Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED

Thanks,
Daniel