netdev - Re: [net-next 07/10] net/mlx5e: Move TC-specific function definitions into MLX5_CLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200623140357.6412f74f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 23 Jun 2020 14:03:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Vlad Buslov <vladbu@...lanox.com>,
        Roi Dayan <roid@...lanox.com>,
        Maor Dickman <maord@...lanox.com>
Subject: Re: [net-next 07/10] net/mlx5e: Move TC-specific function
 definitions into MLX5_CLS_ACT

On Tue, 23 Jun 2020 12:52:26 -0700 Saeed Mahameed wrote:
> From: Vlad Buslov <vladbu@...lanox.com>
> 
> en_tc.h header file declares several TC-specific functions in
> CONFIG_MLX5_ESWITCH block even though those functions are only compiled
> when CONFIG_MLX5_CLS_ACT is set, which is a recent change. Move them to
> proper block.
> 
> Fixes: d956873f908c ("net/mlx5e: Introduce kconfig var for TC support")

and here... do those break build or something?

> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
> Reviewed-by: Roi Dayan <roid@...lanox.com>
> Reviewed-by: Maor Dickman <maord@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>