netdev - Re: [net-next v2 15/15] idpf: Introduce idpf driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200623163857.4e3c219c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 23 Jun 2020 16:38:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, Alan Brady <alan.brady@...el.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Alice Michael <alice.michael@...el.com>,
        Phani Burra <phani.r.burra@...el.com>,
        Joshua Hay <joshua.a.hay@...el.com>,
        Madhu Chittim <madhu.chittim@...el.com>,
        Pavan Kumar Linga <pavan.kumar.linga@...el.com>,
        Donald Skidmore <donald.c.skidmore@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Sridhar Samudrala <sridhar.samudrala@...el.com>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [net-next v2 15/15] idpf: Introduce idpf driver

On Tue, 23 Jun 2020 15:40:43 -0700 Jeff Kirsher wrote:
> +/**
> + * idpf_probe - Device initialization routine
> + * @pdev: PCI device information struct
> + * @ent: entry in idpf_pci_tbl
> + *
> + * Returns 0 on success, negative on failure
> + */
> +int idpf_probe(struct pci_dev *pdev,
> +	       const struct pci_device_id __always_unused *ent)


drivers/net/ethernet/intel/idpf/idpf_main.c:46:5: warning: symbol 'idpf_probe' was not declared. Should it be static?
drivers/net/ethernet/intel/idpf/idpf_main.c:46:5: warning: no previous prototype for idpf_probe [-Wmissing-prototypes]
   46 | int idpf_probe(struct pci_dev *pdev,
      |     ^~~~~~~~~~