netdev - RE: [net-next v2 15/15] idpf: Introduce idpf driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW3PR11MB4522540636AFF28B307A3C8A8F950@MW3PR11MB4522.namprd11.prod.outlook.com>
Date:   Wed, 24 Jun 2020 00:14:14 +0000
From:   "Brady, Alan" <alan.brady@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Michael, Alice" <alice.michael@...el.com>,
        "Burra, Phani R" <phani.r.burra@...el.com>,
        "Hay, Joshua A" <joshua.a.hay@...el.com>,
        "Chittim, Madhu" <madhu.chittim@...el.com>,
        "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>,
        "Skidmore, Donald C" <donald.c.skidmore@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        lkp <lkp@...el.com>
Subject: RE: [net-next v2 15/15] idpf: Introduce idpf driver

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Tuesday, June 23, 2020 4:39 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>
> Cc: davem@...emloft.net; Brady, Alan <alan.brady@...el.com>;
> netdev@...r.kernel.org; nhorman@...hat.com; sassmann@...hat.com;
> Michael, Alice <alice.michael@...el.com>; Burra, Phani R
> <phani.r.burra@...el.com>; Hay, Joshua A <joshua.a.hay@...el.com>; Chittim,
> Madhu <madhu.chittim@...el.com>; Linga, Pavan Kumar
> <pavan.kumar.linga@...el.com>; Skidmore, Donald C
> <donald.c.skidmore@...el.com>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; Samudrala, Sridhar
> <sridhar.samudrala@...el.com>; lkp <lkp@...el.com>
> Subject: Re: [net-next v2 15/15] idpf: Introduce idpf driver
> 
> On Tue, 23 Jun 2020 15:40:43 -0700 Jeff Kirsher wrote:
> > +/**
> > + * idpf_probe - Device initialization routine
> > + * @pdev: PCI device information struct
> > + * @ent: entry in idpf_pci_tbl
> > + *
> > + * Returns 0 on success, negative on failure  */ int
> > +idpf_probe(struct pci_dev *pdev,
> > +	       const struct pci_device_id __always_unused *ent)
> 
> 
> drivers/net/ethernet/intel/idpf/idpf_main.c:46:5: warning: symbol 'idpf_probe'
> was not declared. Should it be static?
> drivers/net/ethernet/intel/idpf/idpf_main.c:46:5: warning: no previous
> prototype for idpf_probe [-Wmissing-prototypes]
>    46 | int idpf_probe(struct pci_dev *pdev,
>       |     ^~~~~~~~~~

Woops, missed one, sorry for the thrash and thanks for double checking.  Will get another version fixing this soon.

Alan