netdev - Re: [EXT] [PATCH v1] bnx2x: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f685dfe2-9a50-15f5-f94f-c72433f84eb1@marvell.com>
Date:   Thu, 25 Jun 2020 19:46:21 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Vaibhav Gupta <vaibhavgupta40@...il.com>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, <bjorn@...gaas.com>,
        Vaibhav Gupta <vaibhav.varodek@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Ariel Elior <aelior@...vell.com>,
        Sudarsana Reddy Kalluru <skalluru@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        <skhan@...uxfoundation.org>
Subject: Re: [EXT] [PATCH v1] bnx2x: use generic power management



On 24/06/2020 8:51 pm, Vaibhav Gupta wrote:
> External Email
> 
> ----------------------------------------------------------------------
> With legacy PM, drivers themselves were responsible for managing the
> device's power states and takes care of register states.
> 
> After upgrading to the generic structure, PCI core will take care of
> required tasks and drivers should do only device-specific operations.
> 
> The driver was also calling bnx2x_set_power_state() to set the power state
> of the device by changing the device's registers' value. It is no more
> needed.
> 
> Compile-tested only.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 15 ++++++---------
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h  |  4 +---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  3 +--
>  3 files changed, 8 insertions(+), 14 deletions(-)

Acked-by: Igor Russkikh <irusskikh@...vell.com>

Sudarsana, could you please give it a short sanity test and report back?

Thanks,
  Igor