netdev - RE: [EXT] [PATCH v1] bnx2x: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR18MB2528DB31A7C55B0D69E7FF0ED3930@MN2PR18MB2528.namprd18.prod.outlook.com>
Date:   Fri, 26 Jun 2020 10:15:52 +0000
From:   Sudarsana Reddy Kalluru <skalluru@...vell.com>
To:     Igor Russkikh <irusskikh@...vell.com>,
        Vaibhav Gupta <vaibhavgupta40@...il.com>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "bjorn@...gaas.com" <bjorn@...gaas.com>,
        Vaibhav Gupta <vaibhav.varodek@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kernel-mentees@...ts.linuxfoundation.org" 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        "skhan@...uxfoundation.org" <skhan@...uxfoundation.org>
Subject: RE: [EXT] [PATCH v1] bnx2x: use generic power management


> -----Original Message-----
> From: Igor Russkikh <irusskikh@...vell.com>
> Sent: Thursday, June 25, 2020 10:16 PM
> To: Vaibhav Gupta <vaibhavgupta40@...il.com>; Bjorn Helgaas
> <helgaas@...nel.org>; Bjorn Helgaas <bhelgaas@...gle.com>;
> bjorn@...gaas.com; Vaibhav Gupta <vaibhav.varodek@...il.com>; David S.
> Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Ariel Elior
> <aelior@...vell.com>; Sudarsana Reddy Kalluru <skalluru@...vell.com>; GR-
> everest-linux-l2 <GR-everest-linux-l2@...vell.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; linux-kernel-
> mentees@...ts.linuxfoundation.org; skhan@...uxfoundation.org
> Subject: Re: [EXT] [PATCH v1] bnx2x: use generic power management
> 
> 
> 
> On 24/06/2020 8:51 pm, Vaibhav Gupta wrote:
> > External Email
> >
> > ----------------------------------------------------------------------
> > With legacy PM, drivers themselves were responsible for managing the
> > device's power states and takes care of register states.
> >
> > After upgrading to the generic structure, PCI core will take care of
> > required tasks and drivers should do only device-specific operations.
> >
> > The driver was also calling bnx2x_set_power_state() to set the power
> > state of the device by changing the device's registers' value. It is
> > no more needed.
> >
> > Compile-tested only.
> >
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>
> > ---
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 15 ++++++---------
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h  |  4 +---
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  3 +--
> >  3 files changed, 8 insertions(+), 14 deletions(-)
> 
> Acked-by: Igor Russkikh <irusskikh@...vell.com>
> 
> Sudarsana, could you please give it a short sanity test and report back?
> 
> Thanks,
>   Igor

I have run the basic sanity test with these changes in the driver, didn’t see any issues.

Thanks,
Sudarsana