netdev - Re: [PATCH net] ionic: update the queue count on open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84163d8c-7e84-e9c9-27c9-f498416764ad@pensando.io>
Date:   Thu, 25 Jun 2020 16:08:30 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net] ionic: update the queue count on open

On 6/25/20 3:57 PM, Jakub Kicinski wrote:
> On Thu, 25 Jun 2020 13:12:15 -0700 Shannon Nelson wrote:
>> Let the network stack know the real number of queues that
>> we are using.
>>
>> Fixes: 49d3b493673a ("ionic: disable the queues on link down")
>> Signed-off-by: Shannon Nelson <snelson@...sando.io>
>> ---
>>   drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> index aaa00edd9d5b..62858c7afae0 100644
>> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> @@ -1673,6 +1673,9 @@ int ionic_open(struct net_device *netdev)
>>   	if (err)
>>   		goto err_out;
>>   
>> +	netif_set_real_num_tx_queues(netdev, lif->nxqs);
>> +	netif_set_real_num_rx_queues(netdev, lif->nxqs);
> These calls can fail.

Ah, yes they can.  I'll update this.

sln