netdev - Re: [PATCH v4 bpf-next 02/14] bpf: Compile resolve_btfids tool at kernel compilation start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZw-asXypkTnzEEn7B86Yy3uUHZaj2qaUxd68hvpS73Eg@mail.gmail.com>
Date:   Fri, 26 Jun 2020 14:28:30 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Martin KaFai Lau <kafai@...com>,
        David Miller <davem@...hat.com>,
        John Fastabend <john.fastabend@...il.com>,
        Wenbo Zhang <ethercflow@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Andrii Nakryiko <andriin@...com>,
        Brendan Gregg <bgregg@...flix.com>,
        Florent Revest <revest@...omium.org>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v4 bpf-next 02/14] bpf: Compile resolve_btfids tool at
 kernel compilation start

On Thu, Jun 25, 2020 at 4:47 PM Jiri Olsa <jolsa@...nel.org> wrote:
>
> The resolve_btfids tool will be used during the vmlinux linking,
> so it's necessary it's ready for it.
>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---

Not sure about clean target, but otherwise looks good to me.

Acked-by: Andrii Nakryiko <andriin@...com>

>  Makefile           | 22 ++++++++++++++++++----
>  tools/Makefile     |  3 +++
>  tools/bpf/Makefile |  5 ++++-
>  3 files changed, 25 insertions(+), 5 deletions(-)
>

[...]

> diff --git a/tools/bpf/Makefile b/tools/bpf/Makefile
> index 6df1850f8353..89ae235b790e 100644
> --- a/tools/bpf/Makefile
> +++ b/tools/bpf/Makefile
> @@ -123,5 +123,8 @@ runqslower_install:
>  runqslower_clean:
>         $(call descend,runqslower,clean)
>
> +resolve_btfids:
> +       $(call descend,resolve_btfids)
> +

I think we talked about this. Did we decide that resolve_btfids_clean
is not necessary?

>  .PHONY: all install clean bpftool bpftool_install bpftool_clean \
> -       runqslower runqslower_install runqslower_clean
> +       runqslower runqslower_install runqslower_clean resolve_btfids
> --
> 2.25.4
>