netdev - Re: [PATCH 2/3] samples: bpf: cleanup pointer error check with libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEKGpzhu+2=kiO6zRMMrBS6PAY4K=WhyOhso99axwHY5mw6Eng@mail.gmail.com>
Date:   Sat, 27 Jun 2020 06:28:53 +0900
From:   "Daniel T. Lee" <danieltimlee@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Yonghong Song <yhs@...com>, Martin KaFai Lau <kafai@...com>,
        Andrii Nakryiko <andriin@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH 2/3] samples: bpf: cleanup pointer error check with libbpf

2020년 6월 27일 (토) 05:25, Andrii Nakryiko <andrii.nakryiko@...il.com>님이 작성:
>
> On Fri, Jun 26, 2020 at 1:18 AM Daniel T. Lee <danieltimlee@...il.com> wrote:
> >
> > Libbpf has its own helper function to check for errors in the bpf
> > data structure (pointer). And Some codes do not use this libbbpf
> > helper function and check the pointer's error directly.
> >
> > This commit clean up the existing pointer error check logic with
> > libbpf.
> >
> > Signed-off-by: Daniel T. Lee <danieltimlee@...il.com>
> > ---
>
> This entire patch is wrong. bpf_object__find_program_by_name() returns
> NULL if the program is not found, not an error code.
>

Oops, I'll drop the patch and resend with the next version.

Thanks for your time and effort for the review.
Daniel

> >  samples/bpf/sampleip_user.c    | 2 +-
> >  samples/bpf/trace_event_user.c | 2 +-
> >  samples/bpf/tracex1_user.c     | 2 +-
> >  samples/bpf/tracex5_user.c     | 2 +-
> >  samples/bpf/tracex7_user.c     | 2 +-
> >  5 files changed, 5 insertions(+), 5 deletions(-)
> >
>
> [...]