netdev - RE: [PATCH iproute2-next 0/4] devlink: Support get,set mac address of a port function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR05MB4866887EA8E214F9B21C04B0D1930@AM0PR05MB4866.eurprd05.prod.outlook.com>
Date:   Fri, 26 Jun 2020 05:13:15 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "stephen@...workplumber.org" <stephen@...workplumber.org>,
        Jiri Pirko <jiri@...lanox.com>,
        "dsahern@...nel.org" <dsahern@...nel.org>
Subject: RE: [PATCH iproute2-next 0/4] devlink: Support get,set mac address of
 a port function

Hi David,

> From: Parav Pandit <parav@...lanox.com>
> Sent: Tuesday, June 23, 2020 4:14 PM
> 
> Currently ip link set dev <pfndev> vf <vf_num> <param> <value> has few below
> limitations.
> 
> 1. Command is limited to set VF parameters only.
> It cannot set the default MAC address for the PCI PF.
> 
> 2. It can be set only on system where PCI SR-IOV is supported.
> In smartnic based system, eswitch of a NIC resides on a different embedded cpu
> which has the VF and PF representors for the SR-IOV support on a host system in
> which this smartnic is plugged-in.
> 
> 3. It cannot setup the function attributes of sub-function described in detail in
> comprehensive RFC [1] and [2].
> 
> This series covers the first small part to let user query and set MAC address
> (hardware address) of a PCI PF/VF which is represented by devlink port.
> 
> Patch summary:
> Patch-1 Sync kernel header
> Patch-2 Move devlink port code at start to reuse
> Patch-3 Extends port dump command to query additional port function
> attribute(s)
> Patch-4 Enables user to set port function hardware address
> 
> [1] https://lore.kernel.org/netdev/20200519092258.GF4655@nanopsycho/
> [2] https://marc.info/?l=linux-netdev&m=158555928517777&w=2
> 

Did you get a chance to review this short series?



> Parav Pandit (4):
>   Update kernel headers
>   devlink: Move devlink port code at start to reuse
>   devlink: Support querying hardware address of port function
>   devlink: Support setting port function hardware address
> 
>  devlink/devlink.c            | 378 ++++++++++++++++++++++++-----------
>  include/uapi/linux/devlink.h |  12 ++
>  2 files changed, 269 insertions(+), 121 deletions(-)
> 
> --
> 2.25.4