netdev - RE: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB67958DCE4BA9D0EC67731049E66E0@DB8PR04MB6795.eurprd04.prod.outlook.com>
Date:   Mon, 29 Jun 2020 05:37:00 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Michael Walle <michael@...le.cc>
CC:     "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature


> -----Original Message-----
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Sent: 2020年6月25日 20:57
> To: Michael Walle <michael@...le.cc>; Joakim Zhang
> <qiangqing.zhang@....com>
> Cc: linux-can@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
> netdev@...r.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature
> 
> On 6/25/20 2:37 PM, Michael Walle wrote:
> > Am 2020-06-02 12:15, schrieb Michael Walle:
> >> Hi Marc,
> >>
> >> Am 2020-04-16 11:41, schrieb Joakim Zhang:
> >>> Hi Marc,
> >>>
> >>> How about FlexCAN FD patch set, it is pending for a long time. Many
> >>> work would base on it, we are happy to see it in upstream mainline
> >>> ASAP.
> >>>
> >>> Michael Walle also gives out the test-by tag:
> >>> 	Tested-by: Michael Walle <michael@...le.cc>
> >>
> >> There seems to be no activity for months here. Any reason for that?
> >> Is there anything we can do to speed things up?
> >
> > ping.. There are no replies or anything. Sorry but this is really
> > annoying and frustrating.
> >
> > Marc, is there anything wrong with the flexcan patches?
> 
> I've cleaned up the patches a bit, can you test this branch:
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kern
> el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fmkl%2Flinux-can-next.git%2
> Flog%2F%3Fh%3Dflexcan&amp;data=02%7C01%7Cqiangqing.zhang%40nxp.co
> m%7Cddbe9019fae84641164508d819073129%7C686ea1d3bc2b4c6fa92cd99c
> 5c301635%7C0%7C0%7C637286865961564061&amp;sdata=Bm0uynxueF%2F
> WpECT8ayfqQxh%2FMYnFCLixvZLvSgUgI4%3D&amp;reserved=0

Hi Marc,

Thank you very much for your effort to clean up the code. I have test the patch set, it can work fine at my side.

But, a patch may be ignored, could you help add back it? Or you are unsatisfied with it, I can improve it according to your opinion.

commit d6ad5cc96229e28e4f2f0960277102ee142577ed
Author: Joakim Zhang <qiangqing.zhang@....com>
Date:   Fri Jul 12 08:02:51 2019 +0000

    can: flexcan: add ISO CAN FD feature support

    ISO CAN FD is introduced to increase the failture detection capability
    than non-ISO CAN FD. The non-ISO CAN FD is still supported by FlexCAN so
    that it can be used mainly during an intermediate phase, for evaluation
    and development purposes.

    Therefore, it is strongly recommended to configure FlexCAN to the ISO
    CAN FD protocol by setting the ISOCANFDEN field in the CTRL2 register.

    NOTE: If you only set "fd on", driver will use ISO FD mode by default.
    You should set "fd-non-iso on" after setting "fd on" if you want to use
    NON ISO FD mode.

    Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
    Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>

And, if it is okay for you, below patch could you also pick up?
can: flexcan: disable runtime PM if register flexcandev failed : https://www.spinics.net/lists/linux-can/msg03146.html


Best Regards,
Joakim Zhang
> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   |
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p
> engutronix.de%2F&amp;data=02%7C01%7Cqiangqing.zhang%40nxp.com%7Cd
> dbe9019fae84641164508d819073129%7C686ea1d3bc2b4c6fa92cd99c5c30163
> 5%7C0%7C0%7C637286865961564061&amp;sdata=U3OQykqsSE35Az9CVznq
> Ck1rl3Hc6UvERaPuh%2BVjHiw%3D&amp;reserved=0  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |