netdev - Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9dc13a697c246a5c7c53bdd89df7d3c7@walle.cc>
Date:   Mon, 29 Jun 2020 18:23:07 +0200
From:   Michael Walle <michael@...le.cc>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     Joakim Zhang <qiangqing.zhang@....com>, linux-can@...r.kernel.org,
        dl-linux-imx <linux-imx@....com>, netdev@...r.kernel.org
Subject: Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

Hi Marc,

> I've cleaned up the patches a bit, can you test this branch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=flexcan

This is working, but as Joakim already said, CAN-FD ISO mode is missing.
It defaults to non-ISO mode, which is even worse, IMHO.

But I've also noticed a difference between the original patch and the
one in that branch. When FD mode is enabled the original patch checks
the priv->can.controlmode [1], the patch in the branch looks at
priv->can.ctrlmode_supported instead [2], is that correct?

-michael

[1] 
https://lore.kernel.org/netdev/20190712075926.7357-4-qiangqing.zhang@nxp.com/
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/tree/drivers/net/can/flexcan.c?h=flexcan&id=5f097cd65cb2b42b88e6e1eb186f6a8f0c90559b#n1341