netdev - Re: [PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 28 Jun 2020 21:00:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linux@...linux.org.uk
Cc:     colton.w.lewis@...tonmail.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3] net: phylink: correct trivial kernel-doc
 inconsistencies

From: Russell King - ARM Linux admin <linux@...linux.org.uk>
Date: Sun, 28 Jun 2020 23:20:36 +0100

> On Sun, Jun 28, 2020 at 09:36:35PM +0000, Colton Lewis wrote:
>> > We seem to be having a communication breakdown.  In review to your
>> > version 2 patch set, I said:
>> > 
>> >    However, please drop all your changes for everything but the
>> >    "struct phylink_config" documentation change; I'm intending to change
>> >    all these method signatures, which means your changes will conflict.
>> > 
>> > But the changes still exist in version 3.  What gives?
>> 
>> You said *drop all your changes* for *everything but* the struct phylink_config change. I interpreted this to mean you wanted *only* struct phylink_config. In context of your previous comments, I might have guessed you meant the opposite.
> 
> It seems we're using different versions of English, because your v4 is
> still wrong.

Aha, ok I'll revert then, thanks.