netdev - Re: [Patch net] net: get rid of lockdep_set_class_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 28 Jun 2020 21:38:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, ap420073@...il.com, dvyukov@...gle.com
Subject: Re: [Patch net] net: get rid of lockdep_set_class_and_subclass()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 26 Jun 2020 11:24:22 -0700

> lockdep_set_class_and_subclass() is meant to reduce
> the _nested() annotations by assigning a default subclass.
> For addr_list_lock, we have to compute the subclass at
> run-time as the netdevice topology changes after creation.
> 
> So, we should just get rid of these
> lockdep_set_class_and_subclass() and stick with our _nested()
> annotations.
> 
> Fixes: 845e0ebb4408 ("net: change addr_list_lock back to static key")
> Suggested-by: Taehee Yoo <ap420073@...il.com>
> Cc: Dmitry Vyukov <dvyukov@...gle.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied.