netdev - Re: [PATCH] Remove handhelds.org links and email addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200629211027.GA1481@kunai>
Date:   Mon, 29 Jun 2020 23:10:27 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>
Cc:     corbet@....net, aaro.koskinen@....fi, tony@...mide.com,
        linux@...linux.org.uk, daniel@...que.org, haojian.zhuang@...il.com,
        robert.jarzmik@...e.fr, kgene@...nel.org, krzk@...nel.org,
        dmitry.torokhov@...il.com, lee.jones@...aro.org,
        ulf.hansson@...aro.org, davem@...emloft.net, kuba@...nel.org,
        b.zolnierkie@...sung.com, j.neuschaefer@....net,
        mchehab+samsung@...nel.org, gustavo@...eddedor.com,
        gregkh@...uxfoundation.org, yanaijie@...wei.com,
        daniel.vetter@...ll.ch, rafael.j.wysocki@...el.com,
        Julia.Lawall@...ia.fr, linus.walleij@...aro.org,
        viresh.kumar@...aro.org, arnd@...db.de, jani.nikula@...el.com,
        yuehaibing@...wei.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-input@...r.kernel.org,
        linux-mmc@...r.kernel.org, netdev@...r.kernel.org,
        linux-parisc@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] Remove handhelds.org links and email addresses

Hi Alexander,

thanks for trying to fix this, yet I have some doubts.

On Mon, Jun 29, 2020 at 10:31:21PM +0200, Alexander A. Klimov wrote:
> Rationale:
> https://lore.kernel.org/linux-doc/20200626110706.7b5d4a38@lwn.net/

I think we need some text here. Clicking on a link to understand what a
patch is about is not comfortable. You can add the link with a Link: tag
for additional information.

Removing stale email addresses may have some value, but removing...

>  Compaq's Bootldr + John Dorsey's patch for Assabet support
> -(http://www.handhelds.org/Compaq/bootldr.html)

... information like this is not good. 'Wayback machine' still has
copies in case someone wants to look at where the infos came from.

> - * Copyright 2004-2005  Phil Blundell <pb@...dhelds.org>
> + * Copyright 2004-2005  Phil Blundell

This is an OK case in my book...


> -MODULE_AUTHOR("Phil Blundell <pb@...dhelds.org>");
> +MODULE_AUTHOR("Phil Blundell");

... same here ...

> @@ -435,7 +435,6 @@
>                             case a PCI bridge (DEC chip 21152). The value of
>                             'pb' is now only initialized if a de4x5 chip is
>                             present.
> -                           <france@...dhelds.org>

This is kind of a signature and should be kept IMO.

>   * 2001/07/23: <rmk@....linux.org.uk>
> - *	- Hand merge version from handhelds.org CVS tree.  See patch
> + *	- Hand merge version from CVS tree.  See patch

That information may be useful.


>  /* SPDX-License-Identifier: GPL-2.0-only */
>  /* -*- linux-c -*-
> - *
> - * (C) 2003 zecke@...dhelds.org

Removing copyright is a bad idea.

Probably some comment blocks are cruft meanwhile and can be removed as a
whole. That can be discussed. But removing only the handhelds.org part
makes most parts worse IMHO.

Thanks and happy hacking,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)