netdev - Re: [PATCH RFC net-next 10/13] net: phylink: in-band pause mode advertisement update for PCS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200630091904.7e477783@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 30 Jun 2020 09:19:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        "michael@...le.cc" <michael@...le.cc>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH RFC net-next 10/13] net: phylink: in-band pause mode
 advertisement update for PCS

On Tue, 30 Jun 2020 15:29:22 +0100 Russell King wrote:
> +	ret = pl->pcs_ops->pcs_config(pl->pcs, pl->cur_link_an_mode,
> +				      pl->link_config.interface,
> +				      pl->link_config.advertising,
> +				      !!(pl->link_config.pause & MLO_PAUSE_AN));

patches 10 and 11 don't build:

drivers/net/phy/phylink.c: In function phylink_change_inband_advert:
drivers/net/phy/phylink.c:485:34: error: struct phylink has no member named pcs
  485 |  ret = pl->pcs_ops->pcs_config(pl->pcs, pl->cur_link_an_mode,
      |                                  ^~
make[4]: *** [drivers/net/phy/phylink.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [drivers/net/phy] Error 2
make[3]: *** Waiting for unfinished jobs....