lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 30 Jun 2020 11:15:35 -0700
From:   Florian Fainelli <>
To:     Russell King <>,
        Andrew Lunn <>,
        Heiner Kallweit <>,
        Ioana Ciornei <>
Cc:     Vladimir Oltean <>,
        Claudiu Manoil <>,
        Alexandru Marginean <>,
        "" <>,
        "" <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
Subject: Re: [PATCH RFC net-next 01/13] net: phylink: update ethtool reporting
 for fixed-link modes

On 6/30/2020 7:28 AM, Russell King wrote:
> Comparing the ethtool output from phylink and non-phylink fixed-link
> setups shows that we have some differences:
> - The "auto-negotiation" fields are different; phylink reports these
>   as "No", non-phylink reports these as "Yes" for the supported and
>   advertising masks.
> - The link partner advertisement is set to the link speed with non-
>   phylink, but phylink leaves this unset, causing all link partner
>   fields to be omitted.
> The phylink ethtool output also disagrees with the software emulated
> PHY dump via the MII registers.
> Update the phylink fixed-link parsing code so that we better reflect
> the behaviour of the non-phylink code that this facility replaces, and
> bring the ethtool interface more into line with the report from via the
> MII interface.
> Signed-off-by: Russell King <>

Reviewed-by: Florian Fainelli <>

Powered by blists - more mailing lists