netdev - Re: [PATCH net-next] mptcp: do nonce initialization at subflow creation time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2006301034001.27064@ptcotton-mobl1.amr.corp.intel.com>
Date:   Tue, 30 Jun 2020 10:39:20 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, mptcp@...ts.01.org,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] mptcp: do nonce initialization at subflow
 creation time


On Tue, 30 Jun 2020, Paolo Abeni wrote:

> This clean-up the code a bit, reduces the number of
> used hooks and indirect call requested, and allow
> better error reporting from __mptcp_subflow_connect()
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> net/mptcp/subflow.c | 54 +++++++++++++++++----------------------------
> 1 file changed, 20 insertions(+), 34 deletions(-)
>

Thanks Paolo, cleanup looks good and it's nice to not rely on the 
rebuild_header hook for this initialization.

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel