netdev - Re: [PATCH v2 net-next 00/16] sfc: prerequisites for EF100 driver, part 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200702140648.10105fd4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 2 Jul 2020 14:06:48 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 00/16] sfc: prerequisites for EF100 driver,
 part 3

On Thu, 2 Jul 2020 17:25:17 +0100 Edward Cree wrote:
> Changes in v2:
> * Patch #1: use efx_mcdi_set_mtu() directly, instead of as a fallback,
>   in the mtu_only case (Jakub)
> * Patch #3: fix symbol collision in non-modular builds by renaming
>   interrupt_mode to efx_interrupt_mode (kernel test robot)
> * Patch #6: check for failure of netif_set_real_num_[tr]x_queues (Jakub)
> * Patch #12: cleaner solution for ethtool drvinfo (Jakub, David)

Thanks, the last two patches with functions with no callers slightly
worrying, but okay:

Reviewed-by: Jakub Kicinski <kuba@...nel.org>