netdev - Re: [PATCH] dsa: rtl8366: Pass GENMASK() signed bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <945fc1cb-c37f-49d5-564c-0786ed9c9d57@gmail.com>
Date:   Sun, 5 Jul 2020 13:49:10 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] dsa: rtl8366: Pass GENMASK() signed bits



On 7/5/2020 1:42 PM, Andrew Lunn wrote:
> Oddly, GENMASK() requires signed bit numbers, so that it can compare
> them for < 0. If passed an unsigned type, we get warnings about the
> test never being true.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

The subject should also be prefixed with "net: " similar to the bcm_sf2
patches you just sent out, with that fixed:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian