netdev - Re: [PATCH net-next 7/7] net: phy: mdio-octeon: Cleanup module loading dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18acb74f-d592-d822-7110-32a50f401154@gmail.com>
Date:   Sun, 5 Jul 2020 13:50:08 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Sunil Goutham <sgoutham@...vell.com>,
        Robert Richter <rrichter@...vell.com>,
        Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH net-next 7/7] net: phy: mdio-octeon: Cleanup module
 loading dependencies



On 7/5/2020 11:29 AM, Andrew Lunn wrote:
> To ensure that the octoen MDIO driver has been loaded, the Cavium

s/octoen/octeon/

> ethernet drivers reference a dummy symbol in the MDIO driver. This
> forces it to be loaded first. And this symbol has not been cleanly
> implemented, resulting in warnings when build W=1 C=1.
> 
> Since device tree is being used, and a phandle points to the PHY on
> the MDIO bus, we can make use of deferred probing. If the PHY fails to
> connect, it should be because the MDIO bus driver has not loaded
> yet. Return -EPROBE_DEFER so it will be tried again later.
Do you also want to add a MODULE_SOFTDEP() to ensure that mdio-octeon is
loaded prior those those modules? This is a hint for modprobe and
libkmod but it would be nicer to have. With that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian