netdev - Re: [PATCH v3 net-next 6/6] net: dsa: felix: use resolved link config in mac_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0b70b3f-f62c-7e9b-5bae-f2a1dafcb4dc@gmail.com>
Date:   Sun, 5 Jul 2020 14:14:32 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...il.com, claudiu.manoil@....com,
        alexandru.marginean@....com, ioana.ciornei@....com,
        linux@...linux.org.uk
Subject: Re: [PATCH v3 net-next 6/6] net: dsa: felix: use resolved link config
 in mac_link_up()



On 7/5/2020 9:16 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Phylink now requires that parameters established through
> auto-negotiation be written into the MAC at the time of the
> mac_link_up() callback. In the case of felix, that means taking the port
> out of reset, setting the correct timers for PAUSE frames, and
> enabling/disabling TX flow control.
> 
> This patch also splits the inband and noinband configuration of the
> vsc9959 PCS (currently found in a function called "init") into 2
> different functions, which have a nomenclature closer to phylink:
> "config", for inband setup, and "link_up", for noinband (forced) setup.
> 
> This is necessary as a preparation step for giving up control of the PCS
> to phylink, which will be done in further patch series.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian