netdev - Re: [PATCH v3 net-next 4/6] net: dsa: felix: set proper pause frame timers based on link speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200705211752.f2jczckp3rgh5hwh@skbuf>
Date:   Mon, 6 Jul 2020 00:17:52 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        vivien.didelot@...il.com, claudiu.manoil@....com,
        alexandru.marginean@....com, ioana.ciornei@....com,
        linux@...linux.org.uk
Subject: Re: [PATCH v3 net-next 4/6] net: dsa: felix: set proper pause frame
 timers based on link speed

Hi Florian,

On Sun, Jul 05, 2020 at 02:09:30PM -0700, Florian Fainelli wrote:
> 
> 
> On 7/5/2020 9:16 AM, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@....com>
> > 
> > state->speed holds a value of 10, 100, 1000 or 2500, but
> > SYS_MAC_FC_CFG_FC_LINK_SPEED expects a value in the range 0, 1, 2 or 3.
> > 
> > So set the correct speed encoding into this register.
> > 
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Did you want to provide a Fixes: tag for this change?
> -- 
> Florian

I am not really sure how fine-grained this really is. Some testing with
dedicated testing equipment was done even with the old values, and I
don't remember that it raised any eyebrows at the time. I would prefer
to not use the "Fixes:" tag here, just to be on the safe side.

Thanks,
-Vladimir