netdev - [PATCH v2] net/appletalk: restore success case for atalk_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Jul 2020 20:11:30 +0900
From:   Chris <chris@...avowed.jp>
To:     netdev@...r.kernel.org
Cc:     trivial@...nel.org
Subject: [PATCH v2] net/appletalk: restore success case for atalk_proc_init()

Commit e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 to
net/appletalk/atalk_proc.c removed the success case, rendering
appletalk.ko inoperable.  This one-liner restores correct operation.

Fixes: e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 ("appletalk: use remove_proc_subtree to simplify procfs code")
Signed-off-by: Christopher KOBAYASHI <chris@...avowed.jp>
---

Apologies for the delay in revising this patch, life got a bit busy.

diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c
index 550c6ca007cc..9c1241292d1d 100644
--- a/net/appletalk/atalk_proc.c
+++ b/net/appletalk/atalk_proc.c
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
 				     sizeof(struct aarp_iter_state), NULL))
 		goto out;
 
+	return 0;
+
 out:
 	remove_proc_subtree("atalk", init_net.proc_net);
 	return -ENOMEM;