netdev - Re: [PATCH net-next] mvpp2: fix pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 Jul 2020 13:03:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mcroce@...ux.microsoft.com
Cc:     netdev@...r.kernel.org, sven.auhagen@...eatech.de,
        linux-kernel@...r.kernel.org, colin.king@...onical.com
Subject: Re: [PATCH net-next] mvpp2: fix pointer check

From: Matteo Croce <mcroce@...ux.microsoft.com>
Date: Tue,  7 Jul 2020 15:19:13 +0200

> From: Matteo Croce <mcroce@...rosoft.com>
> 
> priv->page_pool is an array, so comparing against it will always return true.
> Do a meaningful check by checking priv->page_pool[0] instead.
> While at it, clear the page_pool pointers on deallocation, or when an
> allocation error happens during init.
> 
> Reported-by: Colin Ian King <colin.king@...onical.com>
> Fixes: c2d6fe6163de ("mvpp2: XDP TX support")
> Signed-off-by: Matteo Croce <mcroce@...rosoft.com>

Applied.