netdev - Re: [PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68b95143-53ee-b56d-3452-50fca82e8cd9@alibaba-inc.com>
Date:   Thu, 09 Jul 2020 01:41:45 +0800
From:   "YU, Xiangning" <xiangning.yu@...baba-inc.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 1/2] irq_work: Export symbol
 "irq_work_queue_on"



On 7/8/20 9:55 AM, Eric Dumazet wrote:
> 
> 
> On 7/8/20 9:38 AM, YU, Xiangning wrote:
>> Unlike other irq APIs, irq_work_queue_on is not exported. It makes sense to
>> export it so other modules could use it.
>>
>> Signed-off-by: Xiangning Yu <xiangning.yu@...baba-inc.com>
>> ---
>>  kernel/irq_work.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
>> index eca83965b631..e0ed16db660c 100644
>> --- a/kernel/irq_work.c
>> +++ b/kernel/irq_work.c
>> @@ -111,7 +111,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu)
>>  	return true;
>>  #endif /* CONFIG_SMP */
>>  }
>> -
>> +EXPORT_SYMBOL_GPL(irq_work_queue_on);
>>  
>>  bool irq_work_needs_cpu(void)
>>  {
>>
> 
> 
> ??? You no longer need this change, right ???
> 

Hi Eric,

I didn't find any change about this function from upstream repo. Just double checked, if we don't include this change and ltb is compiled as a module, we will get an undefined symbol. Did I miss anything?

Thanks,
- Xiangning