netdev - Re: [PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200708.123750.2177855708364007871.davem@davemloft.net>
Date:   Wed, 08 Jul 2020 12:37:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiangning.yu@...baba-inc.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] irq_work: Export symbol
 "irq_work_queue_on"

From: "YU, Xiangning" <xiangning.yu@...baba-inc.com>
Date: Thu, 09 Jul 2020 00:38:16 +0800

> @@ -111,7 +111,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu)
>  	return true;
>  #endif /* CONFIG_SMP */
>  }
> -
> +EXPORT_SYMBOL_GPL(irq_work_queue_on);

You either removed the need for kthreads or you didn't.

If you are queueing IRQ work like this, you're still using kthreads.

That's why Eric is asking why you still need this export.