netdev - Re: [PATCH] net: ethernet: mtk_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200708.123646.545653837566811385.davem@davemloft.net>
Date:   Wed, 08 Jul 2020 12:36:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     frank-w@...lic-files.de
Cc:     linux-mediatek@...ts.infradead.org, opensource@...rst.com,
        nbd@....name, john@...ozen.org, sean.wang@...iatek.com,
        Mark-MC.Lee@...iatek.com, kuba@...nel.org, matthias.bgg@...il.com,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: fix mtu warning

From: Frank Wunderlich <frank-w@...lic-files.de>
Date: Wed,  8 Jul 2020 17:46:34 +0200

> From: René van Dorst <opensource@...rst.com>
> 
> in recent Kernel-Versions there are warnings about incorrect MTU-Size
> like these:
> 
> mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x
> eth0: mtu greater than device maximum
> mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
> 
> Signed-off-by: René van Dorst <opensource@...rst.com>
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> 
> Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports")
> Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU")
> Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink extack")

In addition to the other Fixes: tag problems pointed out so far, you should
always put the Fixes: tags first, and immediately before the other tags
such as Signed-off-by: etc. and with no empty lines separating them.

Thank you.