netdev - Re: [PATCH V1 net-next 6/8] net: ena: enable support of rss hash key and function changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200709132311.63720a70@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 9 Jul 2020 13:23:11 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <akiyano@...zon.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>, <dwmw@...zon.com>,
        <zorik@...zon.com>, <matua@...zon.com>, <saeedb@...zon.com>,
        <msw@...zon.com>, <aliguori@...zon.com>, <nafea@...zon.com>,
        <gtzalik@...zon.com>, <netanel@...zon.com>, <alisaidi@...zon.com>,
        <benh@...zon.com>, <ndagan@...zon.com>, <shayagr@...zon.com>,
        <sameehj@...zon.com>
Subject: Re: [PATCH V1 net-next 6/8] net: ena: enable support of rss hash
 key and function changes

On Thu, 9 Jul 2020 22:05:01 +0300 akiyano@...zon.com wrote:
> From: Arthur Kiyanovski <akiyano@...zon.com>
> 
> Add the rss_configurable_function_key bit to driver_supported_feature.
> 
> This bit tells the device that the driver in question supports the
> retrieving and updating of RSS function and hash key, and therefore
> the device should allow RSS function and key manipulation.
> 
> Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com>

Is this a fix of the previous patches? looks strange to just start
advertising a feature bit but not add any code..