netdev - Re: [PATCH V1 net-next 5/8] net: ena: add support for traffic mirroring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Jul 2020 08:56:44 +0000
From:   "Bshara, Nafea" <nafea@...zon.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "Kiyanovski, Arthur" <akiyano@...zon.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>,
        "Dagan, Noam" <ndagan@...zon.com>,
        "Agroskin, Shay" <shayagr@...zon.com>,
        "Jubran, Samih" <sameehj@...zon.com>
Subject: Re: [PATCH V1 net-next 5/8] net: ena: add support for traffic mirroring



Sent from my iPhone

> On Jul 9, 2020, at 11:23 PM, Jakub Kicinski <kuba@...nel.org> wrote:
> 
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
>> On Thu, 9 Jul 2020 22:05:00 +0300 akiyano@...zon.com wrote:
>> From: Arthur Kiyanovski <akiyano@...zon.com>
>> 
>> Add support for traffic mirroring, where the hardware reads the
>> buffer from the instance memory directly.
>> 
>> Traffic Mirroring needs access to the rx buffers in the instance.
>> To have this access, this patch:
>> 1. Changes the code to map and unmap the rx buffers bidirectionally.
>> 2. Enables the relevant bit in driver_supported_features to indicate
>>   to the FW that this driver supports traffic mirroring.
>> 
>> Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com>
> 
> Any more information? You map rx buffers bidirectionally, doesn't mean
> the instance doesn't modify the buffer causing the mirror to see a
> modified frame..  Does the instance wait somehow for the mirror to be
> done, or is the RX completion not generated until mirror operation is
> done?

Rx completion is not generated until mirroring is done