netdev - Re: [PATCH net-next] net: make symbol 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200710.141602.1102731626739852912.davem@davemloft.net>
Date:   Fri, 10 Jul 2020 14:16:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiyongjun1@...wei.com
Cc:     hulkci@...wei.com, kuba@...nel.org, ast@...nel.org,
        daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
        jiri@...lanox.com, edumazet@...gle.com, ap420073@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: make symbol 'flush_works' static

From: Wei Yongjun <weiyongjun1@...wei.com>
Date: Fri, 10 Jul 2020 15:31:04 +0800

> The sparse tool complains as follows:
> 
> net/core/dev.c:5594:1: warning:
>  symbol '__pcpu_scope_flush_works' was not declared. Should it be static?
> 
> 'flush_works' is not used outside of dev.c, so marks
> it static.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Please provide an appropriate Fixes: tag for these kinds of changes.

Thank you.