netdev - Re: [PATCH net] bnxt_en: fix NULL dereference in case SR-IOV configuration fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200710.142054.1540339072424385806.davem@davemloft.net>
Date:   Fri, 10 Jul 2020 14:20:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     michael.chan@...adcom.com, netdev@...r.kernel.org,
        jtoppins@...hat.com, feliu@...hat.com
Subject: Re: [PATCH net] bnxt_en: fix NULL dereference in case SR-IOV
 configuration fails

From: Davide Caratti <dcaratti@...hat.com>
Date: Fri, 10 Jul 2020 12:55:08 +0200

> we need to set 'active_vfs' back to 0, if something goes wrong during the
> allocation of SR-IOV resources: otherwise, further VF configurations will
> wrongly assume that bp->pf.vf[x] are valid memory locations, and commands
> like the ones in the following sequence:
> 
>  # echo 2 >/sys/bus/pci/devices/${ADDR}/sriov_numvfs
>  # ip link set dev ens1f0np0 up
>  # ip link set dev ens1f0np0 vf 0 trust on
> 
> will cause a kernel crash similar to this:
 ...
> Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
> Reported-by: Fei Liu <feliu@...hat.com>
> CC: Jonathan Toppins <jtoppins@...hat.com>
> CC: Michael Chan <michael.chan@...adcom.com>
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied and queued up for -stable, thanks.