netdev - Re: [net-next PATCH v6 2/6] net: phy: introduce device_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Jul 2020 14:36:20 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Calvin Johnson <calvin.johnson@....nxp.com>,
        Jeremy Linton <jeremy.linton@....com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Jon <jon@...id-run.com>,
        Cristi Sovaiala <cristian.sovaiala@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Madalin Bucur <madalin.bucur@....nxp.com>
Cc:     netdev@...r.kernel.org, linux.cj@...il.com,
        linux-acpi@...r.kernel.org
Subject: Re: [net-next PATCH v6 2/6] net: phy: introduce
 device_mdiobus_register()



On 7/10/2020 11:55 PM, Calvin Johnson wrote:
> Introduce device_mdiobus_register() to register mdiobus
> in cases of either DT or ACPI.
> 
> Signed-off-by: Calvin Johnson <calvin.johnson@....nxp.com>
> 
> ---
> 
> Changes in v6:
> - change device_mdiobus_register() parameter position
> - improve documentation
> 
> Changes in v5:
> - add description
> - clean up if else
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  drivers/net/phy/mdio_bus.c | 26 ++++++++++++++++++++++++++
>  include/linux/mdio.h       |  1 +
>  2 files changed, 27 insertions(+)
> 
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index 46b33701ad4b..8610f938f81f 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -501,6 +501,32 @@ static int mdiobus_create_device(struct mii_bus *bus,
>  	return ret;
>  }
>  
> +/**
> + * device_mdiobus_register - register mdiobus for either DT or ACPI
> + * @bus: target mii_bus
> + * @dev: given MDIO device
> + *
> + * Description: Given an MDIO device and target mii bus, this function
> + * calls of_mdiobus_register() for DT node and mdiobus_register() in
> + * case of ACPI.
> + *
> + * Returns 0 on success or negative error code on failure.
> + */
> +int device_mdiobus_register(struct device *dev,
> +			    struct mii_bus *bus)
> +{
> +	struct fwnode_handle *fwnode = dev_fwnode(dev);
> +
> +	if (is_of_node(fwnode))
> +		return of_mdiobus_register(bus, to_of_node(fwnode));
> +	if (fwnode) {
> +		bus->dev.fwnode = fwnode;
> +		return mdiobus_register(bus);
> +	}
> +	return -ENODEV;
> +}
> +EXPORT_SYMBOL(device_mdiobus_register);
> +
>  /**
>   * __mdiobus_register - bring up all the PHYs on a given bus and attach them to bus
>   * @bus: target mii_bus
> diff --git a/include/linux/mdio.h b/include/linux/mdio.h
> index 898cbf00332a..f454c5435101 100644
> --- a/include/linux/mdio.h
> +++ b/include/linux/mdio.h
> @@ -358,6 +358,7 @@ static inline int mdiobus_c45_read(struct mii_bus *bus, int prtad, int devad,
>  	return mdiobus_read(bus, prtad, mdiobus_c45_addr(devad, regnum));
>  }
>  
> +int device_mdiobus_register(struct device *dev, struct mii_bus *bus);

Humm, this header file does not have any of the mii_bus registration
functions declared, and it typically pertains to mdio_device instances
which are devices *on* the mii_bus. phy.h may be more appropriate here
until we break it up into phy_device proper, mii_bus, etc.

>  int mdiobus_register_device(struct mdio_device *mdiodev);
>  int mdiobus_unregister_device(struct mdio_device *mdiodev);
>  bool mdiobus_is_registered_device(struct mii_bus *bus, int addr);
> 

-- 
Florian