netdev - Re: [net-next PATCH v6 5/6] phylink: introduce phylink_fwnode_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <998d1566-ede8-88f4-6c80-cda0c10ca7bf@gmail.com>
Date:   Sat, 11 Jul 2020 14:37:49 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Calvin Johnson <calvin.johnson@....nxp.com>,
        Jeremy Linton <jeremy.linton@....com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Jon <jon@...id-run.com>,
        Cristi Sovaiala <cristian.sovaiala@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Madalin Bucur <madalin.bucur@....nxp.com>
Cc:     netdev@...r.kernel.org, linux.cj@...il.com,
        linux-acpi@...r.kernel.org
Subject: Re: [net-next PATCH v6 5/6] phylink: introduce
 phylink_fwnode_phy_connect()



On 7/10/2020 11:55 PM, Calvin Johnson wrote:
> Define phylink_fwnode_phy_connect() to connect phy specified by
> a fwnode to a phylink instance.
> 
> Signed-off-by: Calvin Johnson <calvin.johnson@....nxp.com>
> 
> ---

[snip]

> +int phylink_fwnode_phy_connect(struct phylink *pl,
> +			       struct fwnode_handle *fwnode,
> +			       u32 flags)
> +{
> +	struct phy_device *phy_dev;
> +
> +	if (is_of_node(fwnode))
> +		return phylink_of_phy_connect(pl, to_of_node(fwnode), flags);
> +	if (is_acpi_device_node(fwnode)) {
> +		phy_dev = phy_find_by_mdio_handle(fwnode);
> +		if (!phy_dev)
> +			return -ENODEV;

Please also assign dev_flags to the phy_dev for symmetry with the
phylink_of_phy_connect() function:

		phy_dev->dev_flags |= flags;

With that fixed:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian