netdev - Re: [PATCH] ip6_gre: fix null-ptr-deref in ip6gre_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <214b051c-c669-61c4-cd3e-5794334c7522@gmail.com>
Date:   Mon, 13 Jul 2020 09:31:54 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>, hulkci@...wei.com,
        Eric Dumazet <eric.dumazet@...il.com>,
        Taehee Yoo <ap420073@...il.com>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] ip6_gre: fix null-ptr-deref in ip6gre_init_net()



On 7/13/20 8:59 AM, Wei Yongjun wrote:
> KASAN report null-ptr-deref error when register_netdev() failed:
> 
>
> 
> ip6gre_tunnel_uninit() has set 'ign->fb_tunnel_dev' to NULL, later
> access to ign->fb_tunnel_dev cause null-ptr-deref. Fix it by saving
> 'ign->fb_tunnel_dev' to local variable ndev.
> 
> Fixes: dafabb6590cb ("ip6_gre: fix use-after-free in ip6gre_tunnel_lookup()")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>