netdev - Re: [PATCH] ip6_gre: fix null-ptr-deref in ip6gre_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200713.173346.220977851123381348.davem@davemloft.net>
Date:   Mon, 13 Jul 2020 17:33:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiyongjun1@...wei.com
Cc:     hulkci@...wei.com, eric.dumazet@...il.com, ap420073@...il.com,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, kuba@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] ip6_gre: fix null-ptr-deref in ip6gre_init_net()

From: Wei Yongjun <weiyongjun1@...wei.com>
Date: Mon, 13 Jul 2020 23:59:50 +0800

> KASAN report null-ptr-deref error when register_netdev() failed:
 ...
> ip6gre_tunnel_uninit() has set 'ign->fb_tunnel_dev' to NULL, later
> access to ign->fb_tunnel_dev cause null-ptr-deref. Fix it by saving
> 'ign->fb_tunnel_dev' to local variable ndev.
> 
> Fixes: dafabb6590cb ("ip6_gre: fix use-after-free in ip6gre_tunnel_lookup()")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Applied and queued up for -stable.