netdev - Re: [PATCH net-next 06/20] net: ipv4: kerneldoc fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Jul 2020 12:38:50 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 06/20] net: ipv4: kerneldoc fixes

On Sun, Jul 12, 2020 at 7:15 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> Simple fixes which require no deep knowledge of the code.
>
> Cc: Paul Moore <paul@...l-moore.com>
> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
>  net/ipv4/cipso_ipv4.c | 6 ++++--
>  net/ipv4/ipmr.c       | 3 +++
>  net/ipv4/tcp_input.c  | 1 -
>  net/ipv4/tcp_output.c | 2 ++
>  net/ipv4/tcp_timer.c  | 2 +-
>  net/ipv4/udp.c        | 6 +++---
>  6 files changed, 13 insertions(+), 7 deletions(-)

Thanks Andrew.  For the cipso_ipv4.c changes ...

Acked-by: Paul Moore <paul@...l-moore.com>

> diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
> index 0f1b9065c0a6..2eb71579f4d2 100644
> --- a/net/ipv4/cipso_ipv4.c
> +++ b/net/ipv4/cipso_ipv4.c
> @@ -283,7 +283,7 @@ static int cipso_v4_cache_check(const unsigned char *key,
>
>  /**
>   * cipso_v4_cache_add - Add an entry to the CIPSO cache
> - * @skb: the packet
> + * @cipso_ptr: pointer to CIPSO IP option
>   * @secattr: the packet's security attributes
>   *
>   * Description:
> @@ -1535,6 +1535,7 @@ unsigned char *cipso_v4_optptr(const struct sk_buff *skb)
>
>  /**
>   * cipso_v4_validate - Validate a CIPSO option
> + * @skb: the packet
>   * @option: the start of the option, on error it is set to point to the error
>   *
>   * Description:
> @@ -2066,7 +2067,7 @@ void cipso_v4_sock_delattr(struct sock *sk)
>
>  /**
>   * cipso_v4_req_delattr - Delete the CIPSO option from a request socket
> - * @reg: the request socket
> + * @req: the request socket
>   *
>   * Description:
>   * Removes the CIPSO option from a request socket, if present.
> @@ -2158,6 +2159,7 @@ int cipso_v4_sock_getattr(struct sock *sk, struct netlbl_lsm_secattr *secattr)
>  /**
>   * cipso_v4_skbuff_setattr - Set the CIPSO option on a packet
>   * @skb: the packet
> + * @doi_def: the DOI structure
>   * @secattr: the security attributes
>   *
>   * Description:

-- 
paul moore
www.paul-moore.com