netdev - Re: [PATCH net-next 3/3] net: treewide: Convert to netdev_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200713133440.1cf65acc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 13 Jul 2020 13:34:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        mkubecek@...e.cz, davem@...emloft.net
Subject: Re: [PATCH net-next 3/3] net: treewide: Convert to
 netdev_ops_equal()

On Sun, 12 Jul 2020 15:16:25 -0700 Florian Fainelli wrote:
> In order to support overloading of netdev_ops which can be done by
> specific subsystems such as DSA, utilize netdev_ops_equal() which allows
> a network driver implementing a ndo_equal operation to still qualify
> whether a net_device::netdev_ops is equal or not to its own.
> 
> Mechanical conversion done by spatch with the following SmPL patch:
> 
>     @@
>     struct net_device *n;
>     const struct net_device_ops o;
>     identifier netdev_ops;
>     @@
> 
>     - n->netdev_ops != &o
>     + !netdev_ops_equal(n, &o)
> 
>     @@
>     struct net_device *n;
>     const struct net_device_ops o;
>     identifier netdev_ops;
>     @@
> 
>     - n->netdev_ops == &o
>     + netdev_ops_equal(n, &o)
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

I think these may be new:

drivers/net/ethernet/ti/cpsw_new.c:1467:30: warning: incorrect type in argument 1 (different modifiers)
drivers/net/ethernet/ti/cpsw_new.c:1467:30:    expected struct net_device *dev
drivers/net/ethernet/ti/cpsw_new.c:1467:30:    got struct net_device const *ndev
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:6185: warning: Function parameter or member 'txqueue' not described in 'ixgbe_tx_timeout'
drivers/net/ethernet/ti/cpsw_new.c: In function ‘cpsw_port_dev_check’:
drivers/net/ethernet/ti/cpsw_new.c:1467:23: warning: passing argument 1 of ‘netdev_ops_equal’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  1467 |  if (netdev_ops_equal(ndev, &cpsw_netdev_ops)) {
       |                       ^~~~