netdev - Re: [PATCH net-next] devlink: Fix use-after-free when destroying health reporters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200713154314.4e6a3cd1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 13 Jul 2020 15:43:14 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        moshe@...lanox.com, vladyslavt@...lanox.com, cai@....pw,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next] devlink: Fix use-after-free when destroying
 health reporters

On Mon, 13 Jul 2020 18:20:14 +0300 Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...lanox.com>
> 
> Dereferencing the reporter after it was destroyed in order to unlock the
> reporters lock results in a use-after-free [1].
> 
> Fix this by storing a pointer to the lock in a local variable before
> destroying the reporter.

Reviewed-by: Jakub Kicinski <kuba@...nel.org>