netdev - Re: [PATCH net-next] devlink: Fix use-after-free when destroying health reporters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200713.173022.1980178714052891828.davem@davemloft.net>
Date:   Mon, 13 Jul 2020 17:30:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, jiri@...lanox.com,
        moshe@...lanox.com, vladyslavt@...lanox.com, cai@....pw,
        mlxsw@...lanox.com, idosch@...lanox.com
Subject: Re: [PATCH net-next] devlink: Fix use-after-free when destroying
 health reporters

From: Ido Schimmel <idosch@...sch.org>
Date: Mon, 13 Jul 2020 18:20:14 +0300

> From: Ido Schimmel <idosch@...lanox.com>
> 
> Dereferencing the reporter after it was destroyed in order to unlock the
> reporters lock results in a use-after-free [1].
> 
> Fix this by storing a pointer to the lock in a local variable before
> destroying the reporter.
> 
> [1]
 ...
> Fixes: 3c5584bf0a04 ("devlink: Rework devlink health reporter destructor")
> Fixes: 15c724b997a8 ("devlink: Add devlink health port reporters API")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reviewed-by: Moshe Shemesh <moshe@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Applied to net-next, thanks.