netdev - Re: [PATCH v2 net-next 04/16] sfc_ef100: skeleton EF100 PF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200714093308.584d69d6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 14 Jul 2020 09:33:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree@...arflare.com>,
        "leon@...nel.org" <leon@...nel.org>
Cc:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 04/16] sfc_ef100: skeleton EF100 PF driver

On Tue, 14 Jul 2020 10:02:05 +0100 Edward Cree wrote:
> On 14/07/2020 00:02, Jakub Kicinski wrote:
> > On Mon, 13 Jul 2020 12:32:16 +0100 Edward Cree wrote:  
> >> +MODULE_VERSION(EFX_DRIVER_VERSION);  
> > We got rid of driver versions upstream, no?  
> The sfc driver still has a MODULE_VERSION(), I just made this do
>  the same.  Should I instead remove the one from sfc as well?

Yes, please.

Leon, I see there's a bunch of MODULE_VERSIONS() still left - are you
planning to take care of those? Perhaps removing them is a good "intern
task"?

> I assumed there was some reason why it hadn't been included in
>  the versionectomy so far.

versionectomy :)