netdev - Re: [PATCH v2 net-next 04/16] sfc_ef100: skeleton EF100 PF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88664bf2-a0c9-4cb1-b50c-2a5e592fe235@solarflare.com>
Date:   Tue, 14 Jul 2020 10:02:05 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 04/16] sfc_ef100: skeleton EF100 PF driver

On 14/07/2020 00:02, Jakub Kicinski wrote:
> On Mon, 13 Jul 2020 12:32:16 +0100 Edward Cree wrote:
>> +MODULE_VERSION(EFX_DRIVER_VERSION);
> We got rid of driver versions upstream, no?
The sfc driver still has a MODULE_VERSION(), I just made this do
 the same.  Should I instead remove the one from sfc as well?
I assumed there was some reason why it hadn't been included in
 the versionectomy so far.

> +static void __exit ef100_exit_module(void)
> +{
> +	pr_info("Solarflare EF100 NET driver unloading\n");
> efx_destroy_reset_workqueue(); ?
Sounds like a good idea, yes.  Good catch.

> Please remove all the uint32_ts
OK.

Thanks for reviewing.
-ed