netdev - Re: [EXT] Re: [PATCH net-next 01/10] net: atlantic: media detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200715154657.GT1078057@lunn.ch>
Date:   Wed, 15 Jul 2020 17:46:57 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Mark Starovoytov <mstarovoitov@...vell.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [EXT] Re: [PATCH net-next 01/10] net: atlantic: media detect

> Hi Andrew,
> 
> Unfortunately I can't verify this on standalone PHY, but some models similar
> to what in AQC107 in theory should.
> 
> Whats your opinion then? Add this feature with phy tunable with ability to
> handle in netdev driver?

Hi Igor

Can you point to some section of the PHY datasheet? I could not find
anything which fit the vague description you have of this feature in
your patch. Maybe Heiner or I can implement and verify the PHY driver
using this feature.

Since this feature can be implemented directly in the PHY driver, and
indirectly via the MAC in firmware, it would be good to have a uniform
interface to do this. So please do add a PHY tunable via MAC driver.

Does the MAC also have the ability to configure PHY downshift? You
could implement that tunable as well.

	  Andrew