netdev - Re: [EXT] Re: [PATCH net-next 03/10] net: atlantic: additional per-queue stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4b9349f-2f3b-e086-a2f6-74e83275741e@marvell.com>
Date:   Wed, 15 Jul 2020 10:58:47 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        "Mark Starovoytov" <mstarovoitov@...vell.com>,
        Dmitry Bogdanov <dbogdanov@...vell.com>
Subject: Re: [EXT] Re: [PATCH net-next 03/10] net: atlantic: additional
 per-queue stats

Thanks for the review, Jakub.

>>  		for (i = 0U, ring = self->ring[0];
>>  			self->tx_rings > i; ++i, ring = self->ring[i]) {
>> +			ring[AQ_VEC_RX_ID].stats.rx.polls++;
> 
> You need to use the u64_stats_update_* infrastructure or make these
> stats smaller than u64, cause on non-64bit machines where the stats
> will be updated 32bit-by-32bit meaning readers can see a half-updated
> counter..

Agree, will secure with stats_update.

>> @@ -314,6 +316,7 @@ irqreturn_t aq_vec_isr(int irq, void *private)
>>  		err = -EINVAL;
>>  		goto err_exit;
>>  	}
>> +	self->ring[0][AQ_VEC_RX_ID].stats.rx.irqs++;

Indeed, looks like some leftover debug counter, will remove.

Thanks,
  Igor